Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example Canvas Themes for CheckbBox and TermsAndConditions #924

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Example Canvas Themes for CheckbBox and TermsAndConditions #924

merged 1 commit into from
Oct 13, 2023

Conversation

barshat7
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 99 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #924 (e58a50c) into dev (d2bb9c5) will not change coverage.
Report is 1 commits behind head on dev.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #924   +/-   ##
=========================================
  Coverage     80.56%   80.56%           
  Complexity      735      735           
=========================================
  Files            91       91           
  Lines          2048     2048           
  Branches        271      271           
=========================================
  Hits           1650     1650           
  Misses          248      248           
  Partials        150      150

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@barshat7 barshat7 merged commit 74cee3b into dev Oct 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-mnnit amit-mnnit amit-mnnit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barshat7 @adobe-bot @amit-mnnit